[Bug 481738] Review Request: python-EnthoughtBase - Core package for the Enthought Tool Suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481738


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #3 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-03-12 13:35:44 EDT ---
Good:
+ Base file name of SPEC file fits with package name
+ Package names fits the naming guidelines
+ URL shows on proper project page
+ Package contains most recent version of the application
+ Could download upstream tar ball via spectool -g
+ Package tar ball matches with upstream
(md5sum: cc555fca3d43c6d8d9ad7a5fdf3e74a1)
+ Consistent usage of prm macros
+ Package contains a valid license tag
+ License tag state BSD and LGPLv2+ as valid OSS licenses
* Package contains verbatin copy of the license text
+ Package contains proper BuildRoot defintion
+ Package contains no patches
* Package contains no subpackages
+ Local build works fine
+ Rpmlint is silent on source package
+ Rpmlint is silent on binary package
+ BuildRoot will be cleaned at the beginning of %clean in %install
+ Package contains a %clean stanza
+ Package is build as noarch
+ Local install works fine
+ Local unisntall works fine
+ Koji build works fine
+ File has proper permission
+ File list has no duplicates
+ Files are owned by this package
+ There are no file with are owned by other package
+ %doc stanza is small
+ Package contains proper %changelog

Bad:
- Please delese the *.egg-info directory in the %prep stanza
- I think the License tag should be BSD and/or LGPLv2+ because
util/buid.py refer to both licenses
- I think you should uncompres docs/html.zip and ToolkitSelection 
ito the %doc stanza

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.