[Bug 488910] Review Request: bio2jack - A library for porting blocked io(OSS/ALSA) applications to jack

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488910





--- Comment #1 from Christian Krause <chkr at plauener.de>  2009-03-12 15:45:29 EDT ---
Hi,

I've just reviewed the package, everything looks good so far. Only about the
license I'm not sure. Please let me ask for a peer-review this time, too. I
expect that after a few more reviews we can skip this step. ;-)

* rpmlint: OK
rpmlint SPECS/bio2jack.spec RPMS/i386/bio2jack-* SRPMS/bio2jack-0.9-1.src.rpm
SPECS/bio2jack.spec:46: W: configure-without-libdir-spec
bio2jack-devel.i386: W: no-documentation
bio2jack.src:46: W: configure-without-libdir-spec
4 packages and 1 specfiles checked; 0 errors, 3 warnings.

- configure-without-libdir-spec is a false positive, since ./configure just
appears in the sed -i -e call

- no-doc - the package doesn't provide any develoment-specific documentation

* naming, spec file name: OK

* license: unsure
- GPL/LGPL both approved by Fedora, however I'm not sure whether this ambiguity
must be solved
- license file included in package

* sources: OK
- spectool -g works
- md5sum: 00b64a99856cb35f1170c97ecb6bc431  bio2jack-0.9.tar.gz

* builds in mock & on all architectures for F11, F10, F9 in koji

* build requirements: OK

* locales: OK, since there are none

* ldconfig in %post, %postun: OK

* owning directory: OK, no directories are created besides %doc

* no files listed twice: OK

* %defattr usage: OK

* %clean section and buildroot clean before install: OK

* macro usage: OK

* code/content: OK, only code

* large documentation into subpackage: OK, no large doc

* header in devel-package: OK

* static libraries: OK (none)

* pkgconfig: OK (no *.pc files)

* *.so link in devel package: OK

* devel package requires fully versioned base pkg: OK

* no *.la files: OK

* *.desktop files: OK (n/a)

* no shared ownership of directories: OK

* filenames in valid UTF-8: OK

* scriptlets: OK (only ldconfig)

* %{optflags} are honored: OK

Best regards,
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.