[Bug 489614] Review Request: perl-Authen-Krb5-Admin - Perl extension for MIT Kerberos 5 admin interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489614


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oget.fedora at gmail.com




--- Comment #4 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-12 23:05:51 EDT ---
Other than the license issue brought up by Jason, I will bring up some issues,
questions and suggestions. (About the license issue, I think we should go with
BSD, since everything that goes into the final binary RPM is BSD.)

* In the build.log I see:
   checking for libk5crypto ... not found (using libcrypto)
This is not found because we have this line in Makefile.PL
   my $KRB5_LIBDIR = "$PREFIX/lib"    ;
I think this line need to be patched or sed'ed to use the correct %{_lib}

! BR: krb5-devel is unnecessary. openssl-devel will pull that up.

? This package owns the same directories with the perl-Authen-Krb5 package. Is
this intentional? Or should this package require perl-Authen-Krb5? I know that
there is an exception rule for perl packages. I was wondering if this package
makes use of that exception rule.

! Please make the description span the 80 columns.

* Each package must consistently use macros. You should either use the "perl,
make, chmod, ..." notation or "%{__perl}, %{__make}, %{__chmod}, ..." notation.
A mixture is not desired.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.