[Bug 483615] Review Request: CodeAnalyst - Performance Analysis Suite for AMD-based System (based on Oprofile)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483615


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #33 from Parag AN(पराग) <panemade at gmail.com>  2009-03-13 00:31:22 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1238767
+ rpmlint output for SRPM and RPM.
CodeAnalyst-gui.i386: W: service-default-enabled /etc/rc.d/init.d/codeanalyst
CodeAnalyst-gui.i386: W: service-default-enabled /etc/rc.d/init.d/codeanalyst
CodeAnalyst-gui.i386: W: incoherent-init-script-name codeanalyst
==> These can be ignored.
+ source files match upstream.
2fb7944b3db827360d4d0e4b9355854c  CodeAnalyst-gui-2.8.38.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files are present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc files are present.
+ no subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig, initscript, users and groups scriptlets are used.
+ package  CodeAnalyst-gui-2.8.38-9.fc11.i586 ->
  Provides: libCA.so.1 libCAbba.so.1 lib_tbp_output.so.1 libopdata.so.1
  Requires: /bin/bash /bin/sh libCA.so.1 libCAbba.so.1 lib_tbp_output.so.1
libbfd-2.19.51.0.2-16.fc11.so libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libdl.so.2 libelf.so.1
libelf.so.1(ELFUTILS_1.0) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0)
libgcc_s.so.1(GLIBC_2.0) libm.so.6 libm.so.6(GLIBC_2.0) libopdata.so.1
libpopt.so.0 libpopt.so.0(LIBPOPT_0) libpthread.so.0 libpthread.so.0(GLIBC_2.0)
libqt-mt.so.3 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(CXXABI_1.3.1) libstdc++.so.6(GLIBCXX_3.4)
libstdc++.so.6(GLIBCXX_3.4.9) rtld(GNU_HASH)

+ Desktop file installed correctly.
+ GUI App.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.