[Bug 453848] Review Request: globus-core - Globus Toolkit - Globus Core

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 13 13:08:26 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453848


Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #12 from Hans de Goede <hdegoede at redhat.com>  2009-03-13 09:08:22 EDT ---
Full review done, looks good, so I'll approve when I'm ready to sponsor you.

2 small things you could change:

1) Put %doc directly under %files
2) Put:
rm -rf autom4te.cache
./bootstrap
   Under %prep, that is where *most* people do autofoo regeneration.

Neither are blockers though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list