[Bug 486758] Review Request: yofrankie-bge - 3D Game with characters from Big Buck Bunny movie

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486758


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #20 from Lubomir Rintel <lkundrak at v3.sk>  2009-03-13 09:28:19 EDT ---
(In reply to comment #19)
> I went forward and did the review. Here it is with few comments:
[...]
> + The License field in the package spec file matches the actual license.
> 
> That is providing, that it'll be changed to "CC-BY and Freely redistributable
> without restriction".

Will do, upon import.

> Source command to export SVN is actually wrong. It should have either "-r 9"
> or "@9" but not combination of those.

Right. It should have been -r9 .. at 9 (meaning revision 9 of what was at this
patch in revision 9).

> Unfortunately, upstream's make system is made in such way so it doesn't
> support paralleling - it compresses one file per time. Perhaps, this
> should be addressed upstream.

This would not be hard to fix, and I may eventually do that in future (either
in make, or just modifying the python script to run number to threads equal to
CPU cores). What would be tricky is compression of the png images into jpeg,
because we only keep those, which are smaller than originals, therefore we
decide whether a target is needed only after we've already remade it.

> This package is APPROVED.  

Thanks a lot for review!

New Package CVS Request
=======================
Package Name: yofrankie-bge
Short Description: 3D Game with characters from Big Buck Bunny movie
Owners: lkundrak
Branches: F-10 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.