[Bug 486390] Review Request: simspark - Spark physical simulation system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486390


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-14 13:27:13 EDT ---
Some notes:

* BR
  - Would you explain where "BR: ImageMagick" is used?
  - "BR: gcc-c++" is redundant.

* Requires
  - Unfortunately, on F-11 dejavu-fonts-sans-mono is renamed
    to dejavu-sans-mono-fonts for some reason...

  - Is it what you expect that simspark main package always
    install ruby? I always have ruby installed on my system
    so I don't care about ruby dependency, however it does
    not seem that this package should always require ruby.

    Maybe splitting files depending on ruby into seperate
    subpackage is preferable.

* Build
  - As you already saw, this package won't build with DevIL
    1.7.8 (i.e. rawhide)

* Cflags
  - build.log shows some compilation information:
------------------------------------------------------------------
[  1%] Building CXX object
utility/tinyxml/CMakeFiles/tinyxml_ex.dir/tinyxml.cpp.o
[  1%] Building C object utility/sfsexp/CMakeFiles/sexp.dir/io.c.o
------------------------------------------------------------------
    which is not useful. Please make build.log more verbose
    (ref:
    https://fedoraproject.org/wiki/Packaging/cmake )

  - And "make VERBOSE=1" actually shows Fedora specific compilation
    flags are not correctly honored, ref:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1241115

  - Also, Fedora's default optimization level is -O2, while
    this package use -O3.

* ldconfig call
  - Calling /sbin/ldconfig on scriptlets is not needed for this
    package because no libraries are installed under default ldconfig
    search paths.
    ! By the way, please check if it is as you expect that no libraries
      are installed under default ldconfig search paths.


(In reply to comment #0)
> Should I add a Conflicts: section to simspark spec file?!  
  - I would write Explicit conflicts "Conflicts: rcssserver3d < 0.6.1",
    however other reviewers may say that it is not needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.