[Bug 478769] Review Request: spring-installer - Installer for the Spring game's maps and mods

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478769





--- Comment #10 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-15 15:13:51 EDT ---
(In reply to comment #9)
> > It does not contains any license at all. Does upstream state anywhere that > > it is GPLv2+?
> 
> It used to be in the debian/copyright file in the previous tarball.
> Debian-specific information has been removed from this new tarball, so this
> file was dropped too. I asked the author to add a COPYING file to the next
> release.

Having COPYING file in tarball does not guarantee that sources are GPL. Plus it
does not specify what version of GPL it is. He should have some README there
telling "This sources are GPL v2 or later" or something like that. Best, if he
includes standard header within comments to every file.

> > It carries a copy of camlzip library. It should be patched to system
> > version of it (package called ocaml-zip).
> 
> I agree, but it requires ocaml-zip version 1.04, and we only have 1.03 in
> Fedora 10. Can I delay the patching until F11 is out ?

Hmm, we don't have ocaml-zip-1.04 in rawhide either. Could you file a bug
against ocaml-zip asking him to update?

> > Debuginfo package looks incomplete. Can it carry anything useful for ocaml
> > programs? May be it should be disabled?
> 
> What makes you say that ? (I am not familiar with ocaml). The OCaml packaging
> guidelines don't say anything about debuginfo packages, so I'd rather leave it
> this way.  

There is no Ocaml sources in debuginfo. That means it's impossible to debug it.
Though, may be, it is possible to get backtraces. So, ok, lets leave it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.