[Bug 489686] Review Request: Armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489686





--- Comment #5 from Michael Schwendt <bugs.michael at gmx.net>  2009-03-16 11:33:15 EDT ---
> %dir %{_docdir}/%{name}-%{version}
> %dir %{_docdir}/%{name}-%{version}/docs_user
> %dir %{_docdir}/%{name}-%{version}/docs_tech
> %dir %{_docdir}/%{name}-%{version}/examples
> %{_docdir}/%{name}-%{version}/*.txt
> %{_docdir}/%{name}-%{version}/index.html
> %{_docdir}/%{name}-%{version}/docs_user/*
> %{_docdir}/%{name}-%{version}/docs_tech/*
> %{_docdir}/%{name}-%{version}/examples/*

Since you create and fill this directory yourself, you can simply replace above
lines with this single line:

%{_docdir}/%{name}-%{version}/

The trailing slash is not important, but makes it more explicit that you
include a directory recursively.


> %dir %{_includedir}/armadillo_bits
> %{_includedir}/armadillo_bits/*

Same here:
%{_includedir}/armadillo_bits/


> Requires:       atlas, lapack, blas, boost

Examine your built package's list of dependencies (rpm --query --requires ...).
If there are automatic dependencies on the atlas/lapack/blas/boost library
SONAMEs, drop above explicit Requires from the spec file. We rely on rpmbuild's
automatic SONAME dependencies:
https://fedoraproject.org/wiki/PackagingDrafts/ExplicitRequires

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.