[Bug 226381] Merge Review: ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226381





--- Comment #23 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-16 13:53:41 EDT ---
For 1.8.6.287-6:

* License
  - As attached, please change the license tag as below:
    ruby-libs -> (GPLv2 or Ruby) and (GPL+ or ASL 1.0)
    ruby-tcltk -> (GPLv2 or Ruby) and TCL
    ruby-rdoc -> (GPLv2 or Ruby) and CC-BY
    Others -> GPLv2 or Ruby

* Source2
  - is found at:
    http://elbereth-hp.hp.infoseek.co.jp/files/ruby/refm/old/2005/list.html

* 64 bits specification
-------------------------------------------------------
%ifarch ppc64 s390x sparc64 x86_64
%patch22 -p1
%patch23 -p1
-------------------------------------------------------
  - Now the following may be better:
-------------------------------------------------------
%if %{__isa_bits} == 64
-------------------------------------------------------

* %check
  - "make test" seems to succeed even on ppc64...
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1244350


* Emacs related directory
  - From emacs-22.3-3 /etc/rpm/macros.emacs (in emacs-common) defines
    %_emacs_sitelispdir %_emacs_sitestartdir. So from F-11
    using these macros is preferred, like:
-------------------------------------------------------
%{!?_emacs_sitelispdir: %global _emacs_sitelispdir /usr/share/emacs/site-lisp}
-------------------------------------------------------
    or so (use %global)

* Convering files into UTF-8
  - There are lots of files named .new left so these should be removed
    (the last " || exit 1" should be "|| rm -f $i.new")

  ! Note that when changing the encoding of HTML files: 
    - usually just changing the encoding to UTF-8 is not enough and
      also changing "charset=foo" item in the HTML files is needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.