[Bug 490508] Review Request: perl-Best - Fallbackable module loader
bugzilla at redhat.com
bugzilla at redhat.com
Tue Mar 17 04:25:02 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490508
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-03-17 00:25:02 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1236078
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0af7afb378e3f8cac5c7af0bf75cfffa Best-0.12.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=23, Tests=101, 1 wallclock secs ( 0.13 usr 0.07 sys + 1.17 cusr 0.25
csys = 1.62 CPU)
+ Package perl-Best-0.12-1.fc11.noarch =>
Provides: perl(Best) = 0.12
Requires: perl >= 0:5.006 perl(constant) perl(overload) perl(strict)
perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list