[Bug 478767] Review Request: spring - Realtime strategy game

Tue Mar 17 10:01:18 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478767

Alexey Torkhov <atorkhov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ianweller at gmail.com         |atorkhov at gmail.com
               Flag|fedora-review?              |fedora-review+

--- Comment #35 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-17 06:01:11 EDT ---
(In reply to comment #33)
> (In reply to comment #32)
> > Other package are reviewed, would you like to finish this?  
> You deserve candy. :)
Thanks for candy :)

Here is the last review:

+ rpmlint output without serious errors:
spring.x86_64: W: dangling-symlink /usr/share/spring/fonts/Luxi.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
spring.x86_64: W: symlink-should-be-relative /usr/share/spring/fonts/Luxi.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
spring.x86_64: W: dangling-symlink /usr/share/spring/fonts/Vera.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
spring.x86_64: W: symlink-should-be-relative /usr/share/spring/fonts/Vera.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
spring.x86_64: E: invalid-soname /usr/lib64/libunitsync.so libunitsync.so
spring.x86_64: W: shared-lib-calls-exit /usr/lib64/libunitsync.so
exit at GLIBC_2.2.5
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zIn.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zAlloc.h
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/LzmaDecode.h
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zHeader.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zIn.h
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zMethodID.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zItem.h
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zAlloc.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zDecode.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zItem.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zMethodID.h
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zExtract.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zCrc.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/LzmaDecode.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zHeader.h
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zBuffer.c
spring-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/spring_0.78.2.1/rts/lib/7zip/7zBuffer.h
3 packages and 0 specfiles checked; 1 errors, 22 warnings.

These should be fixed by using relative symlinks and changing permissions.
Other are safe to ignore.

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
  %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ File, containing the text of the licenses for the package is included in
  %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
  provided in the spec URL.
+ The package successfully compiles and builds into binary rpms on at least
  one primary architecture.
+ Architectures where package does not successfully compile, build or work are
  listed in ExcludeArch.

Bugs should be filled against all 4 spring packages after their acceptance and
added to FE-ExcludeArch-ppc{,64} tracker:
https://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures

+ All build dependencies are listed in BuildRequires.
+ No need to deal with locales.
+ Package does not store shared libraries.
+ The package does not designed to be relocatable.
+ A package owns all directories that it creates.
+ A package does not list a file more than once in the spec %files listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
+ Does not contain large documentation files.
+ Includes only doc files in %doc.
+ No headers.
+ No static libraries.
+ The package does not contain pkgconfig(.pc) files.
+ The package does not contain library files with a suffix (e.g.
  libfoo.so.1.1).
+ No devel packages.
+ The package does not contain any .la libtool archives.
+ Package includes %{name}.desktop file. Properly installed with
  desktop-file-install.
+ The package does not own files or directories already owned by other
  packages.
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in the package are valid UTF-8.
+ The package builds in mock.
+ Used scriptlets are sane.
+ A package does not segfault instead of running.

The Kernel Panic mod is crashing Spring, hopefully not the kernel. CA mod is
crashing too. Backtrace attached. Some other one was working though.
Installer and lobby are working.

And few comments:
Would be better, if it clearly state in description that some mod should be
downloaded to play the game.

In Rawhide dejavu-fonts renamed to dejavu-sans-fonts.

Also, for Rawhide branch, spring-installer should be patched to use
ocaml-zip.

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.