[Bug 470703] Review Request: links 2 - text mode browser with graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470703





--- Comment #16 from Lubomir Rintel <lkundrak at v3.sk>  2009-03-17 09:46:36 EDT ---
0.) links or links2?

#Issue:
#  There is a symlink in /usr/bin/links to elinks if that package is installed
#  Should this package use links2 or should I modify elinks to remove the links
#  symlink from elinks

mv $RPM_BUILD_ROOT/%{_bindir}/links $RPM_BUILD_ROOT/%{_bindir}/links2
mv $RPM_BUILD_ROOT/%{_mandir}/man1/links.1
$RPM_BUILD_ROOT/%{_mandir}/man1/links2.1

Upstream decided to call this "links", not "links2" and changing it needs
careful consideration. I'm all for fixing elinks package not to call its binary
"links" but "elinks", but given this might be controversial and you've
discussed it before I won't block the review for this, but leave the choice up
to you.

When it comes to consistency with other distributors, all operating systems
I've used called the links or links 2 binary "links" (well, Slackware and
NetBSD/pkgsrc).

1.) Sources

Source2:        %{name}.png

Isn't links_32x32.xpm included in the distribution tarball sufficient?  If it
really isn't, include full URL here, or comment on how did you obtain this
file.

2.) Summary contains application name

Summary:        Links is a web browser running in both graphics and text mode

Please remove "Links is a".

3.) Description.

The focus on intuitive usability makes it suitable as a web 
browser for low-end terminals in libraries, Internet cafes etc

This is a joke, right? :)
Seriously, would you install links in an Internet cafe?
Please try to make description more helpful to casual user.

4.) Don't silence make. Its output is useful.

make %{?_smp_mflags} -s

Remove -s

5.) Redundant arguments to %configure

--bindir=%{_bindir} --mandir=%{_mandir}

These are useless, %configure already expands to them. See:

rpm --eval %configure

6.) Icon directory

%files
%{_datadir}/icons/hicolor/48x48/apps

Why do you put the icon here, and own just this directory?
You don't seem to depend on anything that would own %{_datadir}/icons.
Wouldn't /usr/share/pixmaps be a better choice?

7.) Features

You're missing certain features lot of people will find useful:

SSL support:            NO

Links 2 looks for OpenSSL, but openssl-devel is not BuildRequired.
Given Links is distributed under the terms of GPLv2+, you will need exception
from GPL for this from Links upstream. Alternatively, you can use
nss_compat_ossl (patch is already in elinks repository, you
may want to adapt it). See:
http://www.gnome.org/~markmc/openssl-and-the-gpl.html

Graphics drivers:       FB

No X? I'd say X11 is quite popular these days :) Please BuildRequire
libX11-devel

8.) Compile-time warnings

You get a _LOT_ of "pointer targets differ in signedness" warnings.  Please
notify upstream.

9.) Desktop entry

Name=glinks

Please replace this with something more meanungful, such as "Links Web Browser"

Comment=Text mode browser with graphics

This is self-contradictory.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.