[Bug 483615] Review Request: CodeAnalyst-gui - Performance Analysis Suite for AMD-based System (based on Oprofile)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483615


William Cohen <wcohen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wcohen at redhat.com




--- Comment #41 from William Cohen <wcohen at redhat.com>  2009-03-17 10:22:57 EDT ---
Code Analyst currently only builds on x86 platforms and only supports AMD
processors. This is overly restrictive. Both Fedora and OProfile supports a
number of processors architectures. It would be very nice if the Code Analyst
was a bit more flexible and would allow other developers to adapt it those
processor architectures AMD doesn't support. At the very least should be able
to fall back on the oprofile timer mechanism for unknown processors
architectures.

There appears to be a few places with __asm__ code used to either read the
timestamp counter or get the cpuid that would prevent the code from compiling
on non-x86 processors.

$ find -type f -exec grep "__asm__" {} /dev/null \;|more
./src/ca/example/example.cpp:  __asm__ __volatile__ (
./src/ca/example/example.cpp:  __asm__ __volatile__ (
./src/ca/example/example.cpp: __asm__ __volatile__ (       
./src/ca/example/example.cpp: __asm__ __volatile__ (       
./src/ca/gui/auxil.cpp: __asm__ __volatile__ (            
./src/ca/libs/libca/xpwin.cpp:  __asm__ __volatile__ (      
./src/ca/libs/libca/xpwin.cpp: __asm__ __volatile__ (     

These operations could be factored out and converted into defines located in an
include file.

Is the cpuid being used for anything more complicated than just getting the
model and family? Could most of this information be easily obtained from
oprofile's /dev/oprofile/cpu_type or /proc/cpuinfo?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.