[Bug 490562] Review Request: renameutils - A set of programs to make renaming of files easier

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 17 23:23:51 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490562





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-17 19:23:49 EDT ---
A few initial notes:

- the URL
URL:  http://www.nongnu.org/%{name}
would be better as
URL:  http://www.nongnu.org/renameutils

since that way you can open the link straight away from the spec file (you
don't have to expand the macro yourself).

- Remove
Requires: readline
as this is picked up automatically by rpmbuild.

- Locales are not handled correctly, see
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

After you've fixed these I'll make the full review.

Also, as you are a new packager you should make a habit of running rpmlint on
all your packages and paste the output in the Review Request every time you put
in a new release (up to the package being accepted, that is).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list