[Bug 490576] Review Request: bibtex2html - Collection of tools for translating from BibTeX to HTML

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490576





--- Comment #3 from Guido Grazioli <guido.grazioli at gmail.com>  2009-03-17 21:30:47 EDT ---
(In reply to comment #1)
> I can do the review on this one.
> 

Thanks for your suggestions, version below should look better now.

> A few quick notes:
> 
> - change all of the %define:s to %global:s since the behaviour is going to
> change shortly (defines are only meant to be local definitions according to RPM
> specifications).

ok

> - Why do you turn off building of the debug package? Add a comment on this to
> the spec file.

I added a note telling that being written in ocaml, there's no useful debuginfo
data for gdb.

> - You need to preserve time stamps while copying: change all 'cp' to 'cp -p'.

Thanks for that, will take care of it in my next packaging attempts; this time
i could remove the file copying, as i noticed the makefile already takes care
of it.

> - Man pages should not be in %doc; remove the %{doc} prefix from the files
> section for the man pages. Also, you might want to shorten the whole thing to
> just
> %{_mandir}/man1/*.1.gz  

ok

Spec URL:
http://guidograzioli.fedorapeople.org/packages/bibtex2html/bibtex2html.spec
SRPM URL:
http://guidograzioli.fedorapeople.org/packages/bibtex2html/bibtex2html-1.93-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.