[Bug 490576] Review Request: bibtex2html - Collection of tools for translating from BibTeX to HTML

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490576





--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-18 10:49:42 EDT ---
- You should increment the release number every time you make changes to the
package. Now it's hard to tell what changes you have made inbetween versions.
Also remember to add a comment to the changelog about what you have done in
each release.

- Change the source line to use %{version} instead of the version number. This
way when a new version comes out you only need to change the Version: tag.

- Character set conversion is not done safely, use:
for file in CHANGES ; do
   mv $file timestamp && \
   iconv -f ISO-8859-1 -t UTF-8 -o $file timestamp &&  \
   touch -r timestamp $file && \
   rm timestamp
done

- No need to set prefix in %configure, since the %configure macro already does
it (among a bunch of other things). Just use %configure.

- Is there a reason why you're not enabling SMP make? Use 'make
%{?_smp_mflags}' instead of plain 'make'.

- Install phase: use 'make install DESTDIR=$RPM_BUILD_ROOT' instead of 'make
install prefix=%{buildroot} BINDIR=%{buildroot}%{_bindir}
MANDIR=%{buildroot}%{_mandir}'.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.