[Bug 490562] Review Request: renameutils - A set of programs to make renaming of files easier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490562


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #7 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-19 19:19:17 EDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #3)
> > > > Also, as you are a new packager you should make a habit of running rpmlint on
> > > > all your packages and paste the output in the Review Request every time you put
> > > > in a new release (up to the package being accepted, that is).  
> > > 
> > > I'll do that. The only reason I didn't do it is because
> > > https://fedoraproject.org/wiki/Package_Review_Process didn't mention it.
> > > However, for my package rpmlint (0.85) doesn't print any errors/warnings:
> > 
> > Yeah, but it's nicer for the reviewer that way :)
> 
> Should this be mentioned on the wiki?

Uhh, maybe. The reason why it stands at it does now is probably that the
reviewer must in any case run rpmlint on the generated packages. It's just good
practice for the packager to check whether s/he has got everything right before
submitting the package for critisism.

> > - AUTHORS and ChangeLog are missing from documentation.
> 
> ChangeLog mentions that it obsoleted by NEWS and it seems so based on content.
> I just added AUTHORS.

OK.

- Change the summary to "A set of programs to make renaming and copying of
files easier". The current summary is inexact since the package is not purely
about moving, but also copying files. You can do this upon import to CVS
(remember to increment the release, still :)

*****

rpmlint output is clean. The package adheres to Fedora Packaging and Package
Review Guidelines and is thus APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.