[Bug 481717] Review Request: ugene - genome analysis suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481717





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-20 15:57:37 EDT ---
Created an attachment (id=336109)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=336109)
Patch to compile with g++44

Some notes

* Latest
  - The latest version is 1.4.0 (and it seems 1.4.1 will be
    released soon)

* License tag
  - src/libs_3rdparty/qtbindings_core/src/qtscriptconcurrent.h is
    under GPLv2, which renders libqtbindings_core.so to be
    GPLv2.
    So the license tag should be "GPLv2+ and GPLv2".
    Also please write some comments about this on the spec file,
    see:
   
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

* Explicit version dependencies
  - We now request comments on the spec file when you write
    explicit version dependencies for rpms which are automatically
    pulled in by the automated detection of library dependencies
    by rpmbuild itself, see:
    https://fedoraproject.org/wiki/PackagingDrafts/ExplicitRequires
    (this is still under "Drafts" category, but actually this is
     already approved by FESCo)

* Multiple Source entry
  - There are 2 Source entry. Use full URL one:
    https://fedoraproject.org/wiki/Packaging/SourceURL

* 64 bit issue
(In reply to comment #6)
> As long as default rpm macros values are identical to preconfigured paths
> everything goes OK, but when they are not - rpm build will fail. In fact, the
> main problem will be with %{_libdir} since on 64bit platforms it may be changed
> from /usr/lib to /usr/lib64.
> 
> Is there any workaround for this problem (e.g. using hardoced libdir path)?  
  - For this package
-----------------------------------------------------------------
sed -i -e '/UGENE_INSTALL_DIR/s|/lib/|/%{_lib}/|' src/ugene_globals.pri
-----------------------------------------------------------------
    works.

* g++44 compilation issue
  - The attached patch is needed to build this package with g++ 4.4
    (please check if this is already fixed in the latest version or not)

* Functionality
  - By the way:
-----------------------------------------------------------------
$ ugene
Translation not found: transl_ja_JP
Translation not found: transl_en
No translations found, exiting
-----------------------------------------------------------------
    ugene won't launch on my system (note that I am using GNOME)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.