[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476720


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nicolas.mailhot at laposte.net |sanjay_ankur at yahoo.co.in
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(sanjay_ankur at yaho |
                   |o.co.in)                    |




--- Comment #16 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-03-21 07:56:11 EDT ---
Hi Ankur

Some nitpicking:

1. your common_desc declaration is still using define not global

2. I'm not sure doing %clean after %files is a good idea

3. rpmlint complains of
beteckna-fonts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line
1)

4. rpmlint complains of
beteckna-fonts-common.noarch: W: file-not-utf8
/usr/share/doc/beteckna-fonts-common-0.3/CHANGELOG

(see the gfs font specs for examples of txt file recoding to UTF-8)

5. it seems none of those fonts have normal minuscules. Therefore it'd probably
be better to register them as "fantasy" not "sans-serif" in your fontconfig
files

However the rest of the packaging is sane and much better than some of the
stuff I've seen recently and the problems are not worth blocking import

⚶⚶⚶ APPROVED ⚶⚶⚶

Please do consider fixing the remaining small problems however


You can now continue from
https://fedoraproject.org/wiki/Font_package_lifecycle#3.a


As for the warnings emitted by fontforge during build, they unfortunately point
problems in the original upstream file. You should relay them to the font
author(s) so they get fixed.

If you're interested in learning some font creation stuff, you can try to fix
them yourself, and create a patch for upstream. eimai and moyogo on #dejavu
will usually be helpful to people discovering fontforge.

⇒ REASSIGNING now the review is done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.