[Bug 226443] Merge Review: switchdesk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226443





--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-21 18:40:07 EDT ---
rpmlint output:
switchdesk.noarch: W: summary-ended-with-dot A desktop environment switcher for
GNOME, KDE and AnotherLevel.
switchdesk.noarch: E: tag-not-utf8 %changelog
switchdesk.noarch: W: no-url-tag
switchdesk.src: E: non-utf8-spec-file
/tmp/switchdesk-4.0.9-4.fc10.1.src.rpm.25649/switchdesk.spec
switchdesk.src:31: W: unversioned-explicit-obsoletes %{name}-kde
switchdesk.src:32: W: unversioned-explicit-obsoletes %{name}-gnome
switchdesk.src:33: W: unversioned-explicit-provides %{name}-kde
switchdesk.src:34: W: unversioned-explicit-provides %{name}-gnome
switchdesk.src:187: W: macro-in-%changelog _datadir
switchdesk.src: W: summary-ended-with-dot A desktop environment switcher for
GNOME, KDE and AnotherLevel.
switchdesk.src: E: tag-not-utf8 %changelog
switchdesk.src: W: no-url-tag
switchdesk-gui.noarch: W: no-documentation
switchdesk-gui.noarch: E: script-without-shebang
/usr/share/switchdesk/backend.py
switchdesk-gui.noarch: W: summary-ended-with-dot A graphical interface for the
Desktop Switcher.
switchdesk-gui.noarch: E: tag-not-utf8 %changelog
switchdesk-gui.noarch: W: no-url-tag
3 packages and 0 specfiles checked; 5 errors, 12 warnings.

- Need to fix the above errors & warnings.
 * Summary is inexact: switchdesk also works for Fluxbox, FWVM, Icewm etc.
Maybe generalize it to "A desktop environment switcher"? Fix also description.
 * Since url is missing and we are upstream add disclaimer from
http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream

- Missing %doc: AUTHORS COPYING Changelog

- Enable smp make or add note if it doesn't work.

- Remove blank space from end of spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.