[Bug 490028] Review Request: python-tokyocabinet - Python bindings for Tokyo Cabinet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490028


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-23 11:44:05 EDT ---
Some notes:

* %define -> %global
  - Now Fedora suggests to use %global instead of %define, especially
    for the nested macro definition. ref:
    https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
    https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define
    (The latter one says "Draft", however it is already accepted by
    FESCo).

* Naming
  - Fedora prefers to use the tarball name as rpm name as
    much as possible. For this package I recommend to use
    "pytc" as rpm name.

* Requires
----------------------------------------------------------
Requires:       python >= 2.3
Requires:       tokyocabinet
----------------------------------------------------------
  - Both of these are unnecessary. These dependencies are
    automatically pulled in by libraries' dependencies
    caught by rpmbuild itself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.