[Bug 456256] Review Request: frei0r-plugins - Frei0r - a minimalistic plugin API for video effects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456256





--- Comment #6 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2009-03-24 10:18:22 EDT ---
Sorry for not having answeared earlier.

(In reply to comment #1)

> on RPMS:
> frei0r-devel.i386: W: no-documentation
> The package contains no documentation (README, doc, etc). You have to include
> documentation files.
This is optional there is no documentation (this is a warning only)

> Mightn't we want to call frei0r-devel frei0r-plugins-devel, since the base
> pacakge is frei0r-plugins?
It is just a matter of choice, it was keept this way for historical reasons,
When the package was named frei0r-header, but naming it -devel will elect it
for multilibs capability.

> License is good, but I hope gavl turns out to be GPLv2.
gavl is licensed under GPLv3+, as freir-plugins is GPLv2+, this is right.
Do you see a problem with this ?

> What's the status of the patches WRT upstream?
According to the freir current specification, the library path is 
 /usr/lib/frei0r-1/<vendor>, either the main library directoy is /usr/lib64 or
not.
On our side, we cannot accept 64bit shared object to be located in /usr/lib
instead of /usr/lib64. If I remember well, that will need to be fixed in any
application that will use frei0r-plugins. With the change we will introduce,
64bit application compiled on distribution where the main  is /usr/lib
will not be capable of using 64bit native frei0r-plugin on Fedora. (Thus will
be binary incompatible).
A permanent solution will be to add another possible directory to look into
within the frei0r plugin specification.

> Do we not need ldconfig in the post/postun for the main package?
No, we are not in the usual system library case, where shared object are meant
to be linked. We are in the plugin world where unversioned shared object will
be dlopened. So they are not meant to be registered from any system linker
using ldconfig.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.