[Bug 225978] Merge Review: kudzu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225978





--- Comment #7 from Robert Scheck <redhat-bugzilla at linuxnetz.de>  2009-03-24 12:57:24 EDT ---
> > X specfile is properly named, is cleanly written and uses macros consistently.
> > 
> > - dist tag is present.
> >  MUST: Add this.
> 
> It's not listed in Packaging/Guidelines as a must, so I don't think it's 
> really needed.

Notting is right, it's a SHOULD, but no MUST.

> > X BuildRequires are proper.
> >  * Please clean the conflicts, requires and buildrequires. ideally they 
> > should be given one per line in alphabetical order
> 
> Also seems a bit nitpicky, but sure.

Requiring a line for each conflicts, requires and buildrequires seems a waste
of lines. Using space or colon as separator seems much more better to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.