[Bug 458826] Review Request: s390utils - Linux/390 specific utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458826





--- Comment #8 from Jason Tibbitts <tibbs at math.uh.edu>  2009-03-24 21:51:56 EDT ---
A few additional comments:

Is there really no download location for the three tarballs?  If there's any
way to get them, you need to either use full URLs on the Source: lines or, if
the URLs are weird and RPM can't handle them, include them as comments.  See
http://fedoraproject.org/wiki/Packaging/SourceURL.

In a multiple license scenario, there needs to be some documentation of which
parts of the package are under which license.  See
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines

I'm not really sure there's any point in having "Linux -" in those summary
entries.  Isn't it a bit obvious?

The compiler ends up being called with -O3.  I'm not sure this is a big deal,
really, but generally we like to see the default set of compiler flags applied.

I'm pretty sure that everything else about this package is OK, but there's a
lot there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.