[Bug 492039] Review Request: perl-Jemplate - JavaScript Templating with Template Toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492039


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-03-25 00:31:31 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1257482
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
208799c450df16134949ee031b92eef4  Jemplate-0.23.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=20, Tests=140, 22 wallclock secs ( 0.12 usr  0.02 sys +  9.59 cusr  0.71
csys = 10.44 CPU)
+ Package perl-Jemplate-0.23-1.fc11.noarch =>
Provides: perl(Jemplate) = 0.23 perl(Jemplate::Directive)
perl(Jemplate::Grammar) = 2.10 perl(Jemplate::Parser) perl(Jemplate::Runtime)
perl(Jemplate::Runtime::Compact)
Requires: /usr/bin/perl perl >= 0:5.004 perl >= 0:5.006001 perl(Getopt::Long)
perl(Jemplate) >= 0.22 perl(Jemplate::Directive) perl(Jemplate::Grammar)
perl(Jemplate::Parser) perl(Template) >= 2.14 perl(base) perl(lib) perl(strict)
perl(vars) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.