[Bug 491820] Review Request: ibus-sayura - The Sinhala IME engine for IBus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491820


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-03-25 02:06:52 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1257587
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
e426c362f97ddc0647dc732f684e86d9  ibus-sayura-1.0.0.20090324.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.

Suggestions:
1) remove following line from SPEC
rm -f $RPM_BUILD_ROOT%{python_sitearch}/_sayura.la

2) change following line to keep timestamps 
make DESTDIR=${RPM_BUILD_ROOT} install
to
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.