[Bug 491875] Review Request: unzoo - ZOO archive extractor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491875





--- Comment #7 from John W. Linville <linville at redhat.com>  2009-03-25 10:25:17 EDT ---
Spec URL: http://linville.fedorapeople.org/unzoo.spec
SRPM URL: http://linville.fedorapeople.org/unzoo-4.4-2.fc10.src.rpm

- Use 'gcc %{optflags}' for compile
- Remove '-O' from compile command
- Compile %{SOURCE0} to avoid unnecessary copy operation during prep phase
- Move rm -rf %{buildroot} to the top of the install phase
- Generate unzoo.txt from unzoo.c during prep phase and change %doc line to
match
- Use install -Dpm 755 unzoo %{buildroot}%{_bindir}/unzoo
- Add %{?dist} to the Release line

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.