[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484279


Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #2 from Dan Horák <dan at danny.cz>  2009-03-25 13:46:47 EDT ---
formal review is here, see the notes below:

OK source files match upstream, checked with diff
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
N/A debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
BAD doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK* file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- move the *.class removal from %build to %prep
- the %files section for the main package must contain only the *.jar, not the
whole %{_javadir}, use %{_javadir}/*
- use plain %defattr(-,root,root,-) for the javadoc subpackage
- the javadoc documentation shouldn't be marked as %doc and
%{_javadocdir}/%{name} directory should exist, other packages create this as a
symlink to the versioned directory
- all the points above are based on
https://fedoraproject.org/wiki/Packaging/Java

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.