[Bug 476346] Review Request: python-polybori - Framework for Boolean Rings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476346





--- Comment #16 from Conrad Meyer <konrad at tylerc.org>  2009-03-25 19:16:22 EDT ---
(In reply to comment #15)
> - What do you mean by "This doesn't fix it"? Your latest srpm
>   now correctly generates debuginfo rpm (note that of course
>   static archives are ignored)

Sorry, that alone didn't fix it. I also had to make changes via sed to the
SConstruct file.

> - Please check if only "boost-devel" is needed as Requires.
>   For example it seems that "Requires: cudd-devel" is also needed
>   (as polybori/pbori_algo.h contains
>   (However m4ri-devel doesn't seem to be needed for Requires)

Ah, yes, this seems correct.

> - Please remove these undefined non-weak symbols by making
>   those two libraies linked against proper libraries.
> 
>   Most of these undefined symbols on these 2 libraies are actually
>   in libcudd.so.2, for making libpolybori.so and libgroebner.so
>   linked against libcudd.so.2 (by adding "-lcudd" to LDFLAGS or so,
>   for example) will solve _most_ of the problems, but as far as
>   I checked not all.
> 
>   The trouble is that the symbol "_Z12defaultErrorSs" (after demangled
>   it is "defaultError(std::string)") is not defined anywhere.
>   Actually obj/cuddObj.cc in cudd-2.4.1 seems to define this funtion,
>   however build.log for cudd shows that this source is not compiled
>   and so is not included in the libraries in cudd binary rpms.
>   So currently no libraries contain "Z12defaultErrorSs" symbol
>   and this will cause linkage error
> 
>   I guess the code (or Makefiles) in cudd must need fixing so that
>   defaultError(std::string) symbols is actually included in
>   the libraries in cudd.

Ok, I will fix this to link against cudd at build time, and fix cudd to include
that symbol. I wasn't sure if libraries could link to other libraries (I am
fairly new to doing anything beyond basic linking).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.