[Bug 492259] Review Request: tucan - Manager for downloads and uploads at hosting sites

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 26 09:03:21 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492259





--- Comment #3 from Parag AN(पराग) <panemade at gmail.com>  2009-03-26 05:02:56 EDT ---
1) you have missing
BuildRequires:   python
in package.

2) from https://fedoraproject.org/wiki/Packaging:Python#System_Architecture
  you should use %global instead %define

3) either you can create wrapper as
/usr/bin/tucan
#!/bin/sh

/usr/lib/python2.5/site-packages/tucan-0.3.6/tucan.py

or I think good to do it as written in Makefile
        ln -s $(LIBDIR)$(EXECFILE) $(BINDIR)$(NAME)

4) If you are creating patch to makefile then good if you will also add -p to
install and cp commands to preserve timestamps.
see http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list