[Bug 485596] Review Request: phoronix-test-suite - A Comprehensive Linux Benchmarking System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485596





--- Comment #18 from Joseph Smidt <josephsmidt at gmail.com>  2009-03-26 23:21:53 EDT ---
Here are the new packages:

Spec URL: http://jsmidt.fedorapeople.org/phoronix-test-suite.spec
SRPM URL: 
http://jsmidt.fedorapeople.org/phoronix-test-suite-1.6.0-4.fc10.src.rpm

This version deals with the below comments:

> any later version." Perhaps it's worth clarifying with upstream if this should
> be 
> GPLv3 or GPLv3+

Done.

> 
> Should that be mode 755? 

Done


> 3. We may want to think about removing the non free tests here. 
> Since they download non free software, I'm not sure thats something we 
> want to encourage or allow. I guess it's a gray area, but I thought I would 
> bring it up for more discussion. 

I have included a README.Fedora to clear up how to distinguish between non-free
and free tests with as additional statement that Fedora only advocates Free
software.

> 4. I think we should look at handling the deps and downloads a better way. 

As you saw above upstream needs many of these packages to be precise versions. 
I also believe in order to do proper comparisons across different systems it
may be best to leave things how they are.

Feel free to tell me if you disagree.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.