[Bug 488995] Review Request: pidgin-tlen - Tlen IM Pidgin plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488995


Simon Wesp <cassmodiah at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)




--- Comment #1 from Simon Wesp <cassmodiah at fedoraproject.org>  2009-03-27 04:52:01 EDT ---
I didn't find your surname in fas. You need a sponsor, right?
I will add the need sponsor blocker, if i am wrong, then please remove it.

some issues:
--
%global snap 20090209
why global instead of define?
--
%{__make}
please use commands like they are, not as a macro.
make instead of %{__make}
--
BuildRoot Tag
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
your buildroot tag is not valid!
--
%defattr(644,root,root,755)
please use %defattr(-,root,root,-)
--
makro couples 
please use:
$RPM_OPT_FLAGS and $RPM_BUILD_ROOT
or
%{buildroot} and %{optflags}
please use one of this couples, but do not mix this.
--
BuildRequires: pidgin-devel
Requires: pidgin
if you have as BR pidgin-devel, then will rpm requires pidgin automaticly.
you don't need Requires: pidgin
--
this is a tlen plugin, so it will be need 
Requires: libtlen
or?! I didn't test it, yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.