[Bug 492398] Review Request: slv2 - LV2 host library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492398


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bugs.michael at gmx.net
         AssignedTo|nobody at fedoraproject.org    |bugs.michael at gmx.net
               Flag|                            |fedora-review?




--- Comment #2 from Michael Schwendt <bugs.michael at gmx.net>  2009-03-28 06:09:46 EDT ---
> $ pkg-config --libs slv2
> -lrdf -lrasqal -lraptor -lslv2  

> $ pkg-config --libs redland
> -lrdf -lrasqal -lraptor

The slv2.pc file is optimised for static linking in that it adds the
@REDLAND_LIBS@ libs which the shared libslv2 is linked with already. Can be
fixed in both packages.


> export CFLAGS="%{optflags}"
> export CPPFLAGS="%{optflags}"

CPPFLAGS duplicates the CFLAGS during compilation. You want to define CXXFLAGS
instead, although this project is in plain C.


> slv2_plugininstance.h_r1948.diff

Does any slv2 header actually require definitions found within <stdlib.h>? Or
is it just the plugins that ought to include stdlib.h instead? The comment in
the spec doesn't explain this.



* Main slv2 package contains API html documentation, which belongs into the
-devel package. EasyFix.


* Do we have any dependencies for SLV2 already to test with? [Audacity has
dropped SLV2/Redland usage prior to releasing 1.3.7-beta]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.