[Bug 492690] Review Request: kvirc - KVIrc is a free portable IRC client

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 28 19:31:55 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492690





--- Comment #5 from Steven M. Parrish <tuxbrewr at fedoraproject.org>  2009-03-28 15:31:53 EDT ---
Thanks Nucleo for taking this up.  The reason I had postponed it was that with
4.0 in development didn't want to package a legacy kde3 based app.  You've done
a good job getting this working.  Here are 2 issues one of which is a
showstopper.

1st.  Qt4.5 is soon to hit, you need to check with upstream KVIrc devs to make
sure the current code base is compatible.

2nd and the show stopper is this

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

I'll keep an eye on this request and complete the review when its ready.

Steven

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list