[Bug 492094] Review Request: darksnow - GTK Interface for darkice

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492094





--- Comment #1 from Andreas Osowski <th0br0 at mkdir.name>  2009-03-28 18:31:25 EDT ---
Created an attachment (id=337132)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=337132)
generated bug report for darksnow

I tag this review as informal only. I'm looking for a sponsor.

Source0:
Download the source using wget -N to preserve the timestamp of the source

URL:
The page is up just like the source.
http://darksnow.radiolivre.org/pacotes/darksnow-0.6.1.tar.gz

License:
GPLv2+ not just GPLv2 due to "any later"

Install:
Change 
make install PREFIX="%{buildroot}/%{_prefix}/"
to
make install PREFIX="%{buildroot}/%{_prefix}/" INSTALL="install -p"
to preserve the timestamps


Files:
Documentation -- don't use a wildcard!
This way you're installing the file "slack-desc", too -- we probably don't want
it

Running:
The application crashes here (i386) immediately after start. Reason:
*** glibc detected *** darksnow: free(): invalid pointer: 0x098c29d8 ***
(Attached bugreport)
Maybe test the application before packaging?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.