[Bug 454980] Review Request: axel - Download accelerator, wget replacement

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454980





--- Comment #33 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-03-29 17:23:26 EDT ---
(In reply to comment #32)
> axel.i386: E: incorrect-locale-subdir
> /usr/share/locale/zh_cn/LC_MESSAGES/axel.mo
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Hmmm. It is generated by standard %find_lang macros. Where I wrong with it?


> Build uses compiler flags that don't adhere to the Fedora Packaging Guidelines:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
I do not agree with that. configure patched to use those flags. I assume there
all right.


> Buffer overflow warning is still printed. => I won't approve the package.
> Rationale given in earlier comments.  
You are speak about using standard strncat C function:
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might
overflow destination buffer
???

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.