[Bug 226111] Merge Review: lvm2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226111





--- Comment #12 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-30 10:03:02 EDT ---
(In reply to comment #9)
> Source0 with full URL: How does that work?  How does rpmbuild use the URL? 
> What if the person running it has no internet connectivity at the time?  Does
> 'make newbase' use this instead of the 'mirrors' file now?  If not, is there an
> enhancement bugzilla filed to integrate the two so the same info is not stored
> in two places?  

IIUC rpmbuild doesn't use the URL per se, but you can get the sources with
 spectool -g specfile.spec

This way you don't have to download the sources by hand whenever a new version
is released.

(In reply to comment #10)
> We do not 'provide' lvm.
> lvm is the old obsolete package which does not form part of Fedora 10, but
> might be present on a system if someone is installing the rpm on an old system
> and which has to be removed.  'lvm2' version numbers are independent of 'lvm'
> version numbers.  

Okay, it seems I have misunderstood the need for Provides. If lvm2 is not
compatible with lvm, then the provides line must not be there.


(In reply to comment #11)
> What does '%{?_smp_mflags}' expand to?  Then yes, someone needs to tackle
> fixing the build to work with it.  

It's expanded as -j (number of cores on system), as specified in
/usr/lib/rpm/redhat/macros:
%_smp_mflags %([ -z "$RPM_BUILD_NCPUS" ] \\\
        && RPM_BUILD_NCPUS="`/usr/bin/getconf _NPROCESSORS_ONLN`"; \\\
        [ "$RPM_BUILD_NCPUS" -gt 1 ] && echo "-j$RPM_BUILD_NCPUS")

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.