[Bug 485638] Review Request: dmenu - Dynamic X menu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485638


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #3 from Till Maas <opensource at till.name>  2009-03-31 07:24:57 EDT ---
Imho it is better to use a patch instead of the sed commands and modify the
config.mk in a way that you can pass the %{optflags} on the commandline. This
is easier to read and can be submitted upstream.

I also recommend to remove the "@"-signs from the Makefile to see which
commands are actually run, which helps to verify in the build.log, whether or
not the %optflags are really honoured:
sed -i 's/\t@/\t/' Makefile

Btw. strncat is not properly used in dmenu.c, whis is shown in a compiler
warning:
CC dmenu.c                                                                      
In function 'strncat',                                                          
    inlined from 'kpress' at dmenu.c:400,                                       
    inlined from 'run' at dmenu.c:562,                                          
    inlined from 'main' at dmenu.c:725:                                         
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might
overflow destination buffer
Here is a patch by me:
http://till.fedorapeople.org/files/dmenu-3.9-strncat.patch
There is no need to submit it upstream, because they removed the strncat.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.