[Bug 491886] Review Request: xa - 6502/65816 cross assembler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491886





--- Comment #2 from Dan Horák <dan at danny.cz>  2009-03-31 10:56:32 EDT ---
(In reply to comment #1)
> - %{_prefix} should be used instead of /usr in %install
> - you should pass "INSTALL=install -p" to make, to preserve the timestamps of
> the manpages

fixed

> - can you maybe convince upstream to use PREFIX instead of DESTDIR for the
> prefix (/usr/local), but add a $(DESTDIR) in install: to follow common
> practice?  
> - Instead of the chmod a-x for the manpages, you could fix the Makefile to use
> install -m 0644 for the manpages.

will be in a patch that I will submit upstream


Updated Spec URL: http://fedora.danny.cz/xa.spec
Updated SRPM URL: http://fedora.danny.cz/xa-2.3.5-2.fc11.src.rpm

* Tue Mar 31 2009 Dan Horak <dan[at]danny.cz> - 2.3.5-2
- don't use hardcoded /usr
- preserve timestamps when using "install"
- add patch for getline() conflict in recent rawhide

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.