[Bug 490317] Review Request: rumor - Really Unintelligent Music transcriptOR

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 31 21:50:06 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490317


Christian Krause <chkr at plauener.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Christian Krause <chkr at plauener.de>  2009-03-31 17:50:05 EDT ---
all mentioned issues are addressed in the new package:

- compiler optimization flags completely removed, so that only the ones from
the rpmoptflags are used:
g++ -DLOCALEDIR=\"/usr/share/locale\" -DHAVE_CONFIG_H -I. -I. -I..     -O2 -g
-pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -D_REENTRANT -ggdb3  -Wall -pedantic -MT options.o
-MD -MP -MF ".deps/options.Tpo" \
          -c -o options.o

- mixes spaces/tabs in spec file fixed:
rpmlint SPECS/rumor.spec RPMS/i386/rumor-* SRPMS/rumor-1.0.3b-1.fc10.src.rpm 
5 packages and 1 specfiles checked; 0 errors, 0 warnings.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list