[Bug 497682] Review Request: libmemcached - Client library and command line tools for memcached server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497682


Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |terjeros at phys.ntnu.no
               Flag|                            |fedora-review+




--- Comment #10 from Terje Røsten <terjeros at phys.ntnu.no>  2009-05-01 13:16:12 EDT ---

Thanks Remi, patch seems to work. 

Starting full review.

[ x=ok  -=dont't apply  !=please fix ?=may fix ]

MUST
 [x] rpmlint must be run on every package
 [x] package must be named according to the Package Naming Guidelines
 [x] spec file name must match the base package %{name}
 [-] package must meet the Packaging Guidelines
 [x] [BSD] package must be licensed with a Fedora approved license 
 [x] license field in the package spec file must match the actual license
 [x] includes the text of the license(s) in its own file: include in %doc
 [x] be written in American English
 [x] spec file for the package be legible
 [x] sources used to build the package must match the upstream source
 md5sum: 3e022f51301a73ddfc3df32de5b748b19fd97c65 : ok 
 [x] compile and build into binary rpms on at least one architecture
http://koji.fedoraproject.org/koji/taskinfo?taskID=1331611
 [-] not successfully compile an architecture: use ExcludeArch
 [x] all build dependencies must be listed in BuildRequires
 [-] spec file MUST handle locales properly
 [x] shared library files not in any default linker paths: ldconfig
 [-] relocatable package: the packager must state this fact
 [x] package must own all directories that it creates
 [x] not any duplicate files in the %files listing
 [x] permissions on files must be set properly
 [x] package must have a %clean section, which contains rm -rf %{buildroot}
 [x] consistently use macros
 [x] must contain code, or permissable content
 [-] large docs should go in a -doc subpackage
 [x] %doc must not affect the runtime of the application
 [x] header files must be in a -devel package
 [-] static libraries must be in a -static package
 [!] containing pkgconfig(.pc) files must 'Requires: pkgconfig'
  -devel package should have this added.
 [x] library files that end in .so: go in a -devel package
 [x] devel pkg: require base package using a fully versioned dependency
 [x] no .la libtool archives
 [-] gui app include a %{name}.desktop file
 [x] must not own files or directories already owned by other packages
 [x] %install includes rm -rf %{buildroot}
 [x]  filenames in rpm packages must be valid UTF-8
SHOULD
 [x] test that the package builds in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=1331611
 [x] compile and build into binary rpms on all archs
http://koji.fedoraproject.org/koji/taskinfo?taskID=1331611
 [+] package functions as described
 [x] those scriptlets are sane
 [x] subpackages require the base packag  fully versioned dep
 [x] pkgconfig(.pc) in devel
 [x] no explicit file dep outside /etc, /bin/, /sbin, /usr/{sbin,bin}


Add req on pkgconfig in -devel on importing and you are done.

  libmemcached is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.