[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver

bugzilla at redhat.com bugzilla at redhat.com
Sat May 2 06:48:05 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497622





--- Comment #2 from Tim Fenn <fenn at stanford.edu>  2009-05-02 02:48:03 EDT ---
(In reply to comment #1)
> - What's this for?
> 
> %if %{fedora} < 11
> %exclude %{_bindir}/psize.pyc
> %exclude %{_bindir}/psize.pyo
> %endif
> 

A dumb way to prevent byte compiling .py scripts that reside in /usr/bin on F10
but not on -devel:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182498

When I have a chance to build the srpm on my devel machine, i can take this
part out.

> - Instead of
>  pushd bin
>  make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' CPPROG="cp -p"
>  popd
> and so onyou can just use
>  make -C bin install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' CPPROG="cp
> -p"
>  make -C src/aaa_lib install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
> CPPROG="cp -p"
> 

ah, thanks.

> 
> - Why do you generate autoconf files, aren't they distributed in the tarball..?  

Only because I patch the configure.ac and makefile.am files, so the autoconf
stuff needs to be regenerated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list