[Bug 481701] Review Request: python-TraitsGUI - Traits-capable windowing framework

bugzilla at redhat.com bugzilla at redhat.com
Sat May 2 16:51:59 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481701


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #6 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-05-02 12:51:58 EDT ---
OK, I checked everything including the license mess (upstream did a good job in
classifying things though). There are a few minor issues and questions:

! The md5sum you put in the specfile is wrong. But you don't need to put an
md5sum there anyway.

* Each package must consistently use macros: %{__python} needs to be converted
to python

* The new guidelines prefer usage of %global over %define. See:
   http://fedoraproject.org/wiki/Packaging/Python#System_Architecture

? Is there a way of generating/packaging the API docs? How about the docs
directory?

? How about the examples directory?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list