[Bug 498736] Review Request: ucommon - Portable C++ runtime for threads and sockets
bugzilla at redhat.com
bugzilla at redhat.com
Sat May 2 17:40:08 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498736
--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2009-05-02 13:40:07 EDT ---
Some random comments after just glancing at your
spec file:
- First of all please make check that if this is "ucommon"
or "commoncpp". Note that commoncpp is already in Fedora.
- don't define %version, %release. These macros are defined
automatically.
- And why do you want to define %uses_stdcpp ?
- Now Fedora suggests to use %global instead of %define:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
- Duplicating package name in Summary is regarded as
redundant on Fedora.
- Please use license tag valid on Fedora:
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines
https://fedoraproject.org/wiki/Licensing
- BR: gcc-c++ is redundant:
https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- Please don't use "Packager" item. On Fedora this is automatically
defined by buildsys.
- Please use tarball name directly as main package name and
ucommon-devel as development package name. Fedora's naming
rule is different from debian.
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#General_Naming
- Please write %changelog at last and actually write something
on %changelog. ref:
https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
- %setup should be quiet. Please use "%setup -q".
- Please don't use %makeinstall unless avoided:
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
- Don't strip binaries. Debug information is needed to create
debuginfo rpm:
https://fedoraproject.org/wiki/Packaging/Debuginfo
- Please check if document files such as "INSTALL" "BUILDS"
are needed.
I have not read these files (as I am now just watching your spec file)
but these files are usually for people who want to compile/install
packages by themselves and not needed for people using rpm.
- Don't ship static archive or libtool .la files unless needed
by some reason:
https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries
- Package shipping pkgconfig .pc file should have
"Requires: pkgconfig":
https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list