[Bug 495902] Review Request: olpc-kbdshim - grab key and better rotation support for the XO laptop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495902





--- Comment #4 from Paul Fox <pgf at laptop.org>  2009-05-03 00:16:13 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > 
> > okay.  i can't find a reference for %{dist}.  when is it set?
> 
> in rpmmmacros, see http://fedoraproject.org/wiki/Packaging:DistTag
>

thanks.  i seem to have a lot of trouble googling for this kind of thing in the
fedora docs.

> 
> > there won't normally be an upstream tarball location.  the srpm comes from the
> > same place the tarball would -- i.e., git.  so i commented Source0 as in:
> >     https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
> > is that okay?
> 
> Yes, but add a comment how the tarball was generated.

oh!  sorry.  iadded just such a comment, but after i released the version
you're reviewing.  my mistake.  it now says:  "the source tarball is created by
"make tarball" from within a clone of this git tree:
git://dev.laptop.org/users/pgf/olpc-kbdshim"

> > what's the next step?  after fixing, do i build new rpms for you (or someone
> > else) to look at?  or would just a spec file be enough?
> 
> We are reviewing rpms, not specs, so please build a new package for me to
> review. I can also take over sponsorship.

okay.  i'll rebuild after cleaning up the next two issues.

> And of course I have to test this on
> my XO first.
> 
> URL does not work.

it doesn't?  what result do you get?
  URL: http://dev.laptop.org/git/users/pgf/olpc-kbdshim/tree/README
my understanding is that the URL: should lead to more information describing
the package.  since this package doesn't have a home page, a link to the README
seemed appropriate.  not acceptable?

> 
> And worst of all this patching thing wont work. How is one supposed to
> uninstall it? You need at least make a backup of the file that is restored when
> the package is uninstalled. Even this is *very* dirty, i never want to see
> anything like that in Fedora, but maybe we can make an exception for OLPC.
> Alternatives would be much better.  

i expected some issue with that. in defense, the code added by the patch is
conditioned on a check for the existence of a script which is installed by my
package, and so is benign after olpc-kbdshim is uninstalled. if this is
insufficient, i guess i can make a backup, but that feels even uglier to me.

paul

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.