[Bug 498781] Review Request: perl-Catalyst-Plugin-Setenv - Catalyst::Plugin::Setenv Perl module
bugzilla at redhat.com
bugzilla at redhat.com
Sun May 3 15:36:37 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498781
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-05-03 11:36:36 EDT ---
Review:
+ package builds in mock (rawhide i586).
lkoji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1333726
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0c4b9383741e71a2fcad20b2298c3855 Catalyst-Plugin-Setenv-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
Files=5, Tests=13, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.32 cusr 0.06
csys = 0.42 CPU)
+ Package perl-Catalyst-Plugin-Setenv-0.03-1.fc12.noarch ->
Provides: perl(Catalyst::Plugin::Setenv) = 0.03
Requires: perl(MRO::Compat) perl(strict) perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list