[Bug 497283] Review Request: perl-Syntax-Highlight-Engine-Kate - Port to Perl of the syntax highlight engine of the Kate texteditor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497283





--- Comment #3 from Ralf Corsepius <rc040203 at freenet.de>  2009-05-04 02:33:05 EDT ---
(In reply to comment #2)
> The spec was recreated because it is not noarch. 
Please elaborate. I don't see any arch-specific portions inside of this
package.
IMO, this package should be a "noarch" packages.


> The problem in test, which I see is:
> PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
> 'blib/lib', 'blib/arch')" t/*.t                                                 
> t/Kate.t .. 448/? Use of uninitialized value $ch in concatenation (.) or string
> at
> /home/marca/rpmbuild/BUILD/Syntax-Highlight-Engine-Kate-0.04/blib/lib/Syntax/Highlight/Engine/Kate/Template.pm
> line 534.                                                                       
I am also seeing these, but don't have a "quick fix" for it (and no time to
investigate further), sorry.


> I can't still get rid off double perl(Syntax::Highlight::Engine::Kate::Alerts).  

The rpmlint warning stems from these two files inside of the sources:
lib/Syntax/Highlight/Engine/Kate/Alerts
vs.
lib/Syntax/Highlight/Engine/Kate/Alerts.pm

They conflict.

I would suspect "Alerts" to be an outdated version of "Alerts.pm", which likely
was packaged into the tarball by mistake. I'd say, this is something to contact
upstream about to clarify.

For the moment, I'd propose to remove "Alerts" in %prep and to watch how far
you will get. I tried
rm -f lib/Syntax/Highlight/Engine/Kate/Alerts
and found it appears to work.

Further issue: Most permissions of the files inside of the tarball are wrong.
Proposal: Add
find -type f -exec chmod -x {} \;
to %prep

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.