[Bug 499093] Review Request: perl-HTML-WikiConverter - Perl module to convert HTML to wiki markup

bugzilla at redhat.com bugzilla at redhat.com
Tue May 5 08:50:06 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499093


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-05-05 04:50:04 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1336414
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
34cb8ab7f5375aa7836325f9388d6ffe63c475eb  HTML-WikiConverter-0.68.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=71,  2 wallclock secs ( 0.07 usr  0.01 sys +  1.07 cusr  0.08
csys =  1.23 CPU)
+ Package perl-HTML-WikiConverter-0.68-1.fc12.noarch =>
Provides: perl(HTML::WikiConverter) = 0.68
perl(HTML::WikiConverter::Normalizer) perl(HTML::WikiConverter::WebApp)
Requires: perl(CSS) perl(Carp) perl(DirHandle) perl(Encode) perl(File::Spec)
perl(HTML::Element) perl(HTML::Entities) perl(HTML::Tagset)
perl(HTML::TreeBuilder) perl(HTML::WikiConverter)
perl(HTML::WikiConverter::Normalizer) perl(Params::Validate) perl(Tie::IxHash)
perl(URI) perl(URI::Escape) perl(XML::Writer) perl(base) perl(strict)
perl(warnings)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list