[Bug 470696] Review Request: rubygem-passenger - Passenger Ruby on Rails deployment system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470696





--- Comment #31 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-05-05 14:28:38 EDT ---
ell, for 2.2.2-1:

* %define -> %global
  - Please use %global instead of %define:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

* Gem guidelines
  - First of all, this does not follow RubyGem packaging
    guidelines
    A This srpm is not created from original gem file
    B And actually the binary "rubygem-passenger"
      rpm does not work as gem.
      For example, "$ gem list passenger returns nothing.
      This is because specification .gemspec file is missing.
      Also, cached gem file is not installed.

    Well, for A:
    - When using gem as source, applying patches may be difficult.
      However if you want gem file can be expanded as tar archive.
      Also, usually I guess rake file supports "rake gem" to create
      modified gem file
    The issue B is more critical than A.

* Functionality
  - Note that some of (maybe all) scripts under %_bindir don't
    work. For example:
----------------------------------------------------------------
$ passenger-config --version
/usr/bin/passenger-config:27:in `require': no such file to load --
phusion_passenger/constants (LoadError)
 from /usr/bin/passenger-config:27
----------------------------------------------------------------


* Issues from build.log
----------------------------------------------------------------
    92  mkdir -p ext/nginx/libboost_oxt/boost
    93  g++ -Iext  -D_REENTRANT -I/usr/local/include -Wall -g -DPASSENGER_DEBUG
-DBOOST_DISABLE_ASSERTS -o ext/nginx/libboost_oxt/boost/exceptions.o -c
ext/boost/src/pthread/exceptions.cpp
    94  g++ -Iext  -D_REENTRANT -I/usr/local/include -Wall -g -DPASSENGER_DEBUG
-DBOOST_DISABLE_ASSERTS -o ext/nginx/libboost_oxt/boost/once.o -c
ext/boost/src/pthread/once.cpp
----------------------------------------------------------------
  - This still uses internal boost library. Please try to
    use system-wide boost library.
    Note that F-11/12 boost is 1.37.

   And:
----------------------------------------------------------------
   106  g++ -Iext -Iext/common  -D_REENTRANT -I/usr/local/include -Wall -g
-DPASSENGER_DEBUG -DBOOST_DISABLE_ASSERTS -o
ext/nginx/libpassenger_common/Utils.o -c ext/common/Utils.cpp
   107  g++ -Iext -Iext/common  -D_REENTRANT -I/usr/local/include -Wall -g
-DPASSENGER_DEBUG -DBOOST_DISABLE_ASSERTS -o
ext/nginx/libpassenger_common/Logging.o -c ext/common/Logging.cpp
----------------------------------------------------------------
  - Fedora specific compilation flags are not correctly honored.

* Misc cleanups
  ! Note:
    Before fixing below, please change to use gem file as
    source first.
----------------------------------------------------------------
mkdir -p %{buildroot}/%{geminstdir}
mkdir -p %{buildroot}/%{geminstdir} %{buildroot}/%{geminstdir}/lib/ext/
cp -a * %{buildroot}/%{geminstdir}
----------------------------------------------------------------
    - The middle line is not needed.

    - What is the following line for?
----------------------------------------------------------------
cp -a ext/phusion_passenger/native_support.so
%{buildroot}/%{geminstdir}/lib/ext/.
----------------------------------------------------------------

* Directory ownership issue
  - The following directories should be owned by main package,
    not by -devel subpackage:
----------------------------------------------------------------
%{geminstdir}/ext/
%{geminstdir}/ext/apache2/
%{geminstdir}/ext/boost/
----------------------------------------------------------------

  - The ownership of the following directories is unclear:
----------------------------------------------------------------
%{geminstdir}/test/
%{geminstdir}/test/support/
----------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.